Differential D9661

[TabBox] Don't show "Show desktop" window when cycling through application windows
ClosedPublic
Actions

Authored by broulik on Jan 4 2018, 5:51 PM.

Details

Reviewers
graesslin
Group Reviewers
Plasma
VDG
Commits
R108:7ca8771d129f: [TabBox] Don't show "Show desktop" window when cycling through application…
Summary

When I'm explicitly cycling through the windows of an application it makes no sense to show the "global" desktop window.

BUG: 378662
FIXED-IN: 5.12.0

Test Plan

Enabled show desktop in tabbox optioin, Alt+Tab showed "Show desktop".
Alt+` showed only my app's windows, no loinger "Show desktop"

Diff Detail

Repository
R108 KWin
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Jan 4 2018, 5:51 PM
Restricted Application added a project: KWin. · View Herald TranscriptJan 4 2018, 5:51 PM
Restricted Application added subscribers: KWin, kwin, plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jan 4 2018, 5:51 PM
Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptJan 4 2018, 5:51 PM
graesslin added a subscriber: graesslin.Jan 4 2018, 6:22 PM

I'm not sure whether you understood the feature request correctly. I understood it as for the application mode it should not be changed, but for the AllWindowsCurrentApplication the show desktop should be excluded.

Restricted Application edited projects, added KWin; removed Plasma. · View Herald TranscriptJan 4 2018, 6:22 PM
broulik added a comment.Jan 4 2018, 6:24 PM

From what I and Nate understood it makes no sense to have the Desktop window in a list of windows from the same application which this patch addresses

Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptJan 4 2018, 6:24 PM
graesslin added a comment.Jan 4 2018, 6:29 PM
In D9661#186102, @broulik wrote:

From what I and Nate understood it makes no sense to have the Desktop window in a list of windows from the same application which this patch addresses

Yes, but I don't think your patch does that. It also disables it for the "one window per application" mode.

Restricted Application edited projects, added KWin; removed Plasma. · View Herald TranscriptJan 4 2018, 6:29 PM
broulik planned changes to this revision.Jan 4 2018, 6:30 PM

Right, the enum names were confusing.

Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptJan 4 2018, 6:30 PM
graesslin added a comment.Jan 4 2018, 7:09 PM
In D9661#186122, @broulik wrote:

Right, the enum names were confusing.

I was young ;-)

Restricted Application edited projects, added KWin; removed Plasma. · View Herald TranscriptJan 4 2018, 7:09 PM
broulik updated this revision to Diff 24753.Jan 5 2018, 8:52 AM
  • Check for != application windows
Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptJan 5 2018, 8:52 AM
graesslin accepted this revision.Jan 5 2018, 5:25 PM
This revision is now accepted and ready to land.Jan 5 2018, 5:25 PM
Restricted Application edited projects, added KWin; removed Plasma. · View Herald TranscriptJan 5 2018, 5:25 PM
Closed by commit R108:7ca8771d129f: [TabBox] Don't show "Show desktop" window when cycling through application… (authored by broulik). · Explain WhyJan 8 2018, 9:31 AM
This revision was automatically updated to reflect the committed changes.
Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptJan 8 2018, 9:31 AM

Revision Contents
Changeset List

PathPackages
Mtabbox/clientmodel.cpp (3 lines)

Diff 24753

View Options

tabbox/clientmodel.cpp

Loading...