Differential D9658

Use explicit palette interface
ClosedPublic
Actions

Authored by davidedmundson on Jan 4 2018, 5:02 PM.

Details

Reviewers
graesslin
Group Reviewers
Plasma
Commits
R135:0490a151f95b: Use explicit palette interface
Test Plan

Ran new test, with relevant kwin patch decos changes

Diff Detail

Repository
R135 Integration for Qt applications in Plasma
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Jan 4 2018, 5:02 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 4 2018, 5:02 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Jan 4 2018, 5:02 PM
broulik added a subscriber: broulik.Jan 5 2018, 10:02 AM

lgtm

src/platformtheme/kwaylandintegration.cpp
72

Can't we create these the first time an app sets a palette since hardly any apps actually do?

davidedmundson updated this revision to Diff 24765.Jan 5 2018, 12:19 PM

Lazy create the palette manager

graesslin accepted this revision.Jan 5 2018, 5:57 PM
graesslin added a subscriber: graesslin.

Soon my kdevelop will be black again!

This revision is now accepted and ready to land.Jan 5 2018, 5:57 PM
Closed by commit R135:0490a151f95b: Use explicit palette interface (authored by davidedmundson). · Explain WhyJan 5 2018, 6:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 24789

View Options

src/platformtheme/kwaylandintegration.h

Loading...
View Options

src/platformtheme/kwaylandintegration.cpp

Loading...