Check date validity before comparing it
ClosedPublic
Actions

Authored by broulik on Jan 4 2018, 1:05 PM.

Details

Reviewers

mlaurent

Commits

R94:b6534794f87f: Check date validity before comparing it

Summary

Prevents it from treating items with unknown date to be newer than anything else.

BUG: 388521

Test Plan

Configured KMail to select newest email when entering a folder, no longer have it jump to the end of the list to select an "Unknown" email

Repository

R94 PIM: Message Library

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

broulik requested review of this revision.Jan 4 2018, 1:05 PM

broulik created this revision.

Check mi->date() only once

This revision is now accepted and ready to land.Jan 4 2018, 3:31 PM

This revision was automatically updated to reflect the committed changes.

Restricted Application added a subscriber: KDE PIM. · View Herald Transcript

			Path	Packages
M			messagelist/src/core/model.cpp (12 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	24708			Jan 4 2018, 1:04 PM	★	★
Diff 2	24709			Jan 4 2018, 1:07 PM	★	★
Diff 3	24719	a7bf802	R94:b6534794f87f757efe07f4d9498d2db366e0ec5f	Jan 4 2018, 4:33 PM	★	★