In shared-mime-info 1.9 the RW2 mime type has changed from image/x-panasonic-raw2 to image/x-panasonic-rw2, add it to the whitelist
Details
Details
- Reviewers
rkflx - Commits
- R260:484a8df5e435: Fix displaying RW2 files with shared-mime-info 1.9
rw2 files open in gwenview, without the patch it throws an error "Gwenview cannot display documents of type image/x-panasonic-rw2"
Diff Detail
Diff Detail
- Repository
- R260 Gwenview
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
Thanks for the patch.
Looking at the mime database, we have:
- image/x-panasonic-rw with alias image/x-panasonic-raw
- image/x-panasonic-rw2 with alias image/x-panasonic-raw2
I guess it would make sense to also add the missing rw entry? If you agree, please do so.
Otherwise, LGTM. Please commit to Applications/17.12.
Unrelated to this patch, but in case you are interested in further improvements:
- Are there even more raw formats in the database which Gwenview supports via Qt/KF5 and which could be added?
- CR2and NEF open for me in Gwenview from Dolphin, but RW2does not. I guess that's because ./app/org.kde.gwenview.desktop only contains image/tiff, so everything which only has <sub-class-of type="image/x-dcraw"/> does not open in Gwenview by default. Should we claim support for all raw mimetypes or only list specific ones? Do people even want to open raw images with Gwenview? (If not, should we blacklist the tiff-based raw formats too?) Keep in mind D8751#171730.
Comment Actions
Looking at the mime database, we have:
- image/x-panasonic-rw with alias image/x-panasonic-raw
- image/x-panasonic-rw2 with alias image/x-panasonic-raw2
I guess it would make sense to also add the missing rw entry? If you agree, please do so.
Agreed, done