Generated headers, which may be required by client packages, are installed
into a private and version specific include dir to indicate that they may
not be stable.
To use the parser in client packages simply add kdevphpparser with
target_link_libraries to a target. Parser related headers need to be
prefixed with <parser/...> e.g. #include <parser/tokenstream.h>.
BUG:388370
compiled on linux, verified with patched umbrello build
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Not really a cmake expert. Changes look sound, but can't really judge whether they are correct. Generally looks fine to me, apart from installing the php.g grammar file.
| parser/CMakeLists.txt | ||
|---|---|---|
| 53 | Seems a bit odd to me to install the grammar file. Afaics phpparser.h is generated from it and should have everything one needs, no? | |
| CMakeLists.txt | ||
|---|---|---|
| 1–2 | project(kdev-php VERSION 5.1.2) please. And then just PROJECT_VERSION & friends below. | |
| 18 | We'll have a hard time updating the kdev-php version via scripts then. | |
| 52 | Why that? I guess that should be CMAKE_CURRENT_BINARY_DIR? | |
| parser/CMakeLists.txt | ||
| 29 | Can be merged in one single target_include_directories(...) call. | |
| 53 | +1 | |
| CMakeLists.txt | ||
|---|---|---|
| 52 | no, otherwise there are compile errors: [ 27%] Building CXX object parser/CMakeFiles/kdevphpparser.dir/phpparser.cpp.o from /home/xxx/src/kdev-php-build/parser/phpparser.cpp:4: /home/xxx/src/kdev-php-build/parser/phptokentype.h:13:32: fatal error: parser/tokenstream.h: Could not find file or directory This is because headers are installed in related subdirectories e.g. files inside parser subdir are installed in <include-install-root>/parser/... and references other files from this dir with this prefix, see php.g | |
Just to be exact: This patch is against 5.1 branch, from which the stable version (at least on opensuse Leap 42.3) has been build https://software.opensuse.org/package/kdevelop5-plugin-php?search_term=kdevelop5-plugin-php