Differential D9614

Tablet hotplug detection for xlib backend
AbandonedPublic
Actions

Authored by valeriymalov on Jan 2 2018, 6:29 PM.

Details

Reviewers
xuetianweng
fvogt
Summary

This is based on kcm_keyboard's implementation of device detection
Make xcb-xinput backend optional even if you meet the requirements
(this is controlled via cmake -DUSE_XCB_XINPUT=OFF)

Test Plan
  • Compile (with -DUSE_XCB_XINPUT=OFF if you have xcb-xinput)
  • See if hotplug still works, see that we don't blow up kded eventually

Diff Detail

Repository
R530 Wacom tablet support
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
valeriymalov requested review of this revision.Jan 2 2018, 6:29 PM
valeriymalov created this revision.
fvogt added a comment.EditedJan 2 2018, 6:37 PM

I did it slightly different in https://phabricator.kde.org/D9576 already.

So which one is the one that should get picked?

(Edit: I hit "save changes" too early by accident)

valeriymalov added a comment.Jan 2 2018, 6:39 PM

Oh, I'm very sorry, somehow I didn't notice it :/ I should check my phabricator email settings.

I'll take a look.

valeriymalov abandoned this revision.Jan 2 2018, 7:12 PM

Superseded by D9576

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (13 lines)
Msrc/kded/x11eventnotifier-xlib.cpp (52 lines)

Diff 24616

View Options

CMakeLists.txt

Loading...
View Options

src/kded/x11eventnotifier-xlib.cpp

Loading...