Differential D9611

Transaction should not have a timeout.
ClosedPublic
Actions

Authored by sbwsbw on Jan 2 2018, 2:30 PM.

Details

Reviewers
sitter
vanini
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
R548:46f45d734f5d: dpkg -i should not have a timeout
Summary

BUG: 387659

Diff Detail

Repository
R548 QAPT Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sbwsbw requested review of this revision.Jan 2 2018, 2:30 PM
sbwsbw created this revision.
sbwsbw added a reviewer: cfeck.
cfeck edited reviewers, added: sitter, vanini; removed: cfeck.Jan 2 2018, 3:30 PM
sitter requested changes to this revision.Jan 4 2018, 12:06 PM

Thanks. The code looks good to me. The comment is useless though, so I'd rather have that changed.

src/worker/aptworker.cpp
207

I am not sure what use this comment has, given it does not tell us why the next line does what it does, but rather that it does what the code says it does.

You will want to either document why waiting indefinitely is the right way here, or not have a comment at all.

(also, waiting is spelled with one t)

This revision now requires changes to proceed.Jan 4 2018, 12:06 PM
sbwsbw updated this revision to Diff 24812.Jan 6 2018, 5:37 AM

remove comment line.

ngraham edited the summary of this revision. (Show Details)Jan 6 2018, 6:12 AM
sitter accepted this revision.Jan 8 2018, 2:10 AM
This revision is now accepted and ready to land.Jan 8 2018, 2:10 AM
Closed by commit R548:46f45d734f5d: dpkg -i should not have a timeout (authored by sitter). · Explain WhyJan 8 2018, 2:16 AM
This revision was automatically updated to reflect the committed changes.
Owners added a reviewer: Restricted Owners Package.Jan 8 2018, 2:16 AM

Revision Contents
Changeset List

PathPackages
Msrc/worker/aptworker.cpp (2 lines)

Diff 24915

View Options

src/worker/aptworker.cpp

Loading...