Move Ui::adblock to private section
ClosedPublic
Actions

Authored by dvratil on Feb 17 2016, 7:40 PM.

Details

Reviewers

mlaurent

Summary

Instead of inheriting a generated class from public API, make the Ui class a private member instead.

Lint

Lint Skipped

Unit

Unit Tests Skipped

dvratil retitled this revision from to Move Ui::adblock to private section.

dvratil updated this object.

dvratil edited the test plan for this revision. (Show Details)

dvratil added a reviewer: mlaurent.

dvratil set the repository for this revision to R94 PIM: Message Library.

Don't install the header file

dvratil added a project: KDE PIM.

Seems ok thanks

This revision is now accepted and ready to land.Feb 20 2016, 6:03 AM

I commited your patch.
Another user had problem to build messageviewer

			Path	Packages
M			messageviewer/src/CMakeLists.txt (1 line)
M			messageviewer/src/adblock/common/adblocksettingwidget.h (12 lines)
M			messageviewer/src/adblock/common/adblocksettingwidget.cpp (165 lines)
M			messageviewer/src/adblock/tests/adblocksettingsdialog_gui.cpp (2 lines)