Differential D9599

Create interface for passing server decoration palettes
ClosedPublic
Actions

Authored by davidedmundson on Jan 2 2018, 10:01 AM.

Details

Reviewers

graesslin

Group Reviewers

Plasma

Commits

R127:dec26d932914: Create interface for passing server decoration palettes

Summary

It's kept separate in case we ever merge the server decoration manager
interface upstream, and this is too kwin specific to have in a
potentially shared spec.

Code is a copy+paste of existing boilerplate.

Replaces use of the deprecated qt extended surface.

I'd like to target 5.42 as otherwise we'll have a regression when we
release Plasma 5.12 as Qt's XDGv6 doesn't have a working qt extended
surface.

Test Plan

Attached unit test

Diff Detail

Repository

R127 KWayland

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

davidedmundson created this revision.Jan 2 2018, 10:01 AM

Restricted Application added projects: Plasma on Wayland, Frameworks. · View Herald TranscriptJan 2 2018, 10:01 AM

Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript

davidedmundson requested review of this revision.Jan 2 2018, 10:01 AM

Restricted Application edited projects, added Plasma; removed Plasma on Wayland. · View Herald TranscriptJan 2 2018, 10:01 AM

replace tiny typo

Restricted Application edited projects, added Plasma on Wayland; removed Plasma. · View Herald TranscriptJan 2 2018, 10:13 AM

graesslin accepted this revision.Jan 2 2018, 4:36 PM

This revision is now accepted and ready to land.Jan 2 2018, 4:36 PM

Restricted Application edited projects, added Plasma; removed Plasma on Wayland. · View Herald TranscriptJan 2 2018, 4:36 PM

Closed by commit R127:dec26d932914: Create interface for passing server decoration palettes (authored by davidedmundson). · Explain WhyJan 3 2018, 10:39 AM

This revision was automatically updated to reflect the committed changes.

Restricted Application edited projects, added Plasma on Wayland; removed Plasma. · View Herald TranscriptJan 3 2018, 10:39 AM

Revision Contents
Changeset List

		Path
M		autotests/client/CMakeLists.txt (12 lines)
M		src/client/CMakeLists.txt (7 lines)
A	M	src/client/protocols/server-decoration-palette.xml (43 lines)
M		src/client/registry.h (57 lines)
M		src/client/registry.cpp (11 lines)
A	M	src/client/server_decoration_palette.h (197 lines)
A	M	src/client/server_decoration_palette.cpp (184 lines)
M		src/server/CMakeLists.txt (10 lines)
M		src/server/display.h (11 lines)
M		src/server/display.cpp (8 lines)
A	M	src/server/server_decoration_palette_interface.h (106 lines)
A	M	src/server/server_decoration_palette_interface.cpp (216 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	24565	9121e68		Jan 2 2018, 10:01 AM	★	★
Diff 2	24569	9121e68	replace tiny typo	Jan 2 2018, 10:13 AM	★	★
Diff 3	24655	3d0d490	R127:dec26d9329141d52940229206cb9eaf01a0ddc09	Jan 3 2018, 10:34 AM	★	★