Move calls depending on $DISPLAY from startplasmacompositor to startplasma
ClosedPublic

Authored by fvogt on Jan 1 2018, 8:54 PM.

Details

Summary

Xwayland is only available within startplasma, so only call xprop in
startplasma.
Additionally, the environment isn't complete within startplasmacompositor,
as $DISPLAY needs to be exported to the activation environment as well.

BUG: 377122

Test Plan

pinentry-qt works now when started from gpg-agent.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
fvogt created this revision.Jan 1 2018, 8:54 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 1 2018, 8:54 PM
fvogt requested review of this revision.Jan 1 2018, 8:54 PM
davidedmundson requested changes to this revision.Jan 2 2018, 1:11 PM
davidedmundson added a subscriber: davidedmundson.

Copying my bugzilla coment.

If you *moved* that call we'd need to be absolutely sure that kwin doesn't make any DBus calls before startplasma has finished processing that.

Given kwin calls kactivitymanagerd and kded (for nightmode), that's not easy to do safely.

Doing it twice would work though.


I know you've replying showing it happens to work for the one case, but that's not the same thing as being safe.

This revision now requires changes to proceed.Jan 2 2018, 1:11 PM
fvogt updated this revision to Diff 24589.Jan 2 2018, 1:27 PM

I don't see any such calls in kwin_wayland before the session is started, but sure.

Looks good to me. Personally I would split it into two commits.

davidedmundson accepted this revision.Jan 2 2018, 4:56 PM

+1 from me too

Thanks

This revision is now accepted and ready to land.Jan 2 2018, 4:56 PM
This revision was automatically updated to reflect the committed changes.