Change Python libraries install location
ClosedPublic

Authored by alvinhochun on Dec 31 2017, 5:01 PM.

Details

Summary

This moves the Python libraries install location to ${LIB_INSTALL_DIR}/krita-python-libs, separated from the bundled Python plugins in share/krita/pykrita.

The idea is that the libraries/modules shouldn't be mixed together with the loadable plugin scripts, and that they should be more cleanly separated in different locations. Though I'm not sure if they should remain in share/ or be moved to lib/. I chose the latter since PyKrita is a native module.

After making these changes, these steps will be needed before rebuilding:

  • Remove share/krita/pykrita/*
  • On Windows, ext_sip and ext_pyqt in 3rdparty/ will need to be rebuilt

Alternatively, a complete rebuild will get it working.

I've tested and verified on these setups:

  • Windows 64-bit with a complete clean build (including deps), embedded Python
  • KDE Neon with system-wide Python/SIP/PyQt install (installed with apt)

This is a diff combined from series of related changes. The individual commits against master can be viewed here: https://github.com/KDE/krita/compare/master...alvinhochun:alvin/pykrita-update
You can fetch my branch by running git fetch https://github.com/alvinhochun/krita.git alvin/pykrita-update

Diff Detail

Repository
R37 Krita
Lint
Lint Skipped
Unit
Unit Tests Skipped
alvinhochun created this revision.Dec 31 2017, 5:01 PM
Restricted Application added a subscriber: woltherav. · View Herald TranscriptDec 31 2017, 5:01 PM
alvinhochun requested review of this revision.Dec 31 2017, 5:01 PM
alvinhochun updated this revision to Diff 24665.Jan 3 2018, 1:53 PM

Changed the order of the Python paths.
Also rebased my branch onto master.

alvinhochun updated this revision to Diff 24666.Jan 3 2018, 1:55 PM
rempt accepted this revision.Jan 4 2018, 1:22 PM
This revision is now accepted and ready to land.Jan 4 2018, 1:22 PM
This revision was automatically updated to reflect the committed changes.