Differential D9576

Implement hotplugging on Xlib
ClosedPublic
Actions

Authored by fvogt on Dec 31 2017, 1:56 PM.

Details

Reviewers
valeriymalov
Commits
R530:17d5878d56da: Implement hotplugging on Xlib
Summary

Register for events using Xlib and read them using Xcb.
This is a mixture of the method used in
qtbase/src/plugins/platforms/xcb/qxcbconnection_xi2.cpp
and plasma-desktop's ca7618dd6173db8a8f0e36d91a38a1d4ac7d0706

BUG: 361743

Test Plan

Restarted kded after make install, plugging and unplugging
causes notifications.

Diff Detail

Repository
R530 Wacom tablet support
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
fvogt requested review of this revision.Dec 31 2017, 1:56 PM
fvogt created this revision.
valeriymalov accepted this revision.Jan 2 2018, 7:03 PM

Seems good to me, works for me too.

I'd pick this one since it's closer to xcb backend implementation.

This revision is now accepted and ready to land.Jan 2 2018, 7:03 PM
fvogt added a comment.Jan 2 2018, 7:10 PM

Ok, thanks!

It might even be possible to merge both x11eventnotifier "backends" into one x11eventnotifier.cpp that way,
depending on whether one big #ifdef is better or worse than multiple smaller #ifdef

Closed by commit R530:17d5878d56da: Implement hotplugging on Xlib (authored by fvogt). · Explain WhyJan 2 2018, 7:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (2 lines)
Msrc/kded/x11eventnotifier-xlib.cpp (102 lines)

Diff 24617

View Options

CMakeLists.txt

Loading...
View Options

src/kded/x11eventnotifier-xlib.cpp

Loading...