Differential D9570

Make XMLUI file validate agaist XSD
AbandonedPublic
Actions

Authored by schwarzer on Dec 30 2017, 8:23 PM.

Details

Reviewers
None
Group Reviewers
KDE Games
Summary

To me it seems that XMLUI files need at least an empty MenuBar element within the gui element.
I tried to remove the XMLUI file completely but could not find a way to build the result. Comments welcome. :D

Test Plan

Ran "xmllint --noout --debugent --schema ../kxmlgui.xsd kbreakoutui.rc" without errors/warnings
Built -> Installed -> Played the game

Diff Detail

Repository
R393 KBreakout
Lint
Lint Skipped
Unit
Unit Tests Skipped
schwarzer requested review of this revision.Dec 30 2017, 8:23 PM
schwarzer created this revision.
schwarzer edited the test plan for this revision. (Show Details)
aacid added a subscriber: aacid.Jan 1 2018, 11:27 PM

This is not really needed, i.e. the xsd is not really accurate of what the code expects since this gets merged with the default rc file we will already have a menubar.

If you feel strongly about having the file validate, sure commit it, otherwise it's not really worth it in my opinion.

schwarzer added a comment.Jan 3 2018, 7:29 PM
In D9570#184689, @aacid wrote:

This is not really needed, i.e. the xsd is not really accurate of what the code expects since this gets merged with the default rc file we will already have a menubar.

If you feel strongly about having the file validate, sure commit it, otherwise it's not really worth it in my opinion.

Krazy complains about it and people can see the defects number so they might want to fix little things. So if the file is alright that way and we can silence Krazy about it, I would be happy as well.

schwarzer abandoned this revision.Jan 16 2021, 10:43 AM
Restricted Application added a subscriber: kde-games-devel. · View Herald TranscriptJan 16 2021, 10:43 AM

Revision Contents
Changeset List

PathPackages
Msrc/kbreakoutui.rc (4 lines)

Diff 24504

View Options

src/kbreakoutui.rc

Loading...