Penalty: Fix layout for vertical mode
ClosedPublic

Authored by ganeshredcobra on Dec 30 2017, 1:53 PM.

Details

Reviewers
scagarwal
Group Reviewers
GCompris
Maniphest Tasks
T7612: Penalty: Fix layout for vertical mode
Summary

Penalty: Fix layout for vertical mode

Diff Detail

Repository
R2 GCompris
Lint
Lint Skipped
Unit
Unit Tests Skipped
ganeshredcobra created this revision.Dec 30 2017, 1:53 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptDec 30 2017, 1:53 PM
Restricted Application added a subscriber: KDE Edu. · View Herald Transcript

@ganeshredcobra The instruction image is better suited up when it is on the right on the screen with respect to user not the left side.

updated the icon to right side of the screen

scagarwal added a comment.EditedDec 30 2017, 7:46 PM

@ganeshredcobra Can you share a picture of correction ?

@ganeshredcobra Can you share a picture of correction ?

Screenshot of change

https://pasteboard.co/H0EXx2v.png

scagarwal accepted this revision as: scagarwal.Dec 31 2017, 2:33 AM
scagarwal added a subscriber: asagtani.

@asagtani , This looks good. Do review it ?

This revision is now accepted and ready to land.Dec 31 2017, 2:33 AM
asagtani added inline comments.Dec 31 2017, 7:50 AM
src/activities/penalty/Penalty.qml
179

No need for left margin here and you should keep the right margin at least 10 so that it will not look attached to the right edge.

Removed Left Margin and gave 10 right margin

jjazeix closed this revision.Dec 31 2017, 6:02 PM
jjazeix added a subscriber: jjazeix.

committed, thank you :)