libinput/connection: Don't hardcode seat0 anymore
ClosedPublic

Authored by nerdopolist on Dec 29 2017, 5:20 PM.

Details

Summary

use a new function to get the logind, instead of assuming seat0

Test Plan

kwin still starts

Diff Detail

Repository
R108 KWin
Lint
Lint Skipped
Unit
Unit Tests Skipped
nerdopolist created this revision.Dec 29 2017, 5:20 PM
Restricted Application added a subscriber: kwin. · View Herald TranscriptDec 29 2017, 5:20 PM

Is there anything that needs to be changed with this one?

rkflx added subscribers: graesslin, rkflx.EditedMar 21 2018, 11:48 AM

@nerdopolist Please rebase on latest master and update authorship information on Phab:

git fetch
git checkout 50b948134c81
arc patch D9552
git rebase origin/master
# Check if it still compiles
arc diff

@graesslin Friendly ping to review the code afterwards ;)

davidedmundson accepted this revision.Mar 24 2018, 11:58 PM
davidedmundson added a subscriber: davidedmundson.
davidedmundson added inline comments.
libinput/connection.cpp
141

why remove the seat name from here?

This revision is now accepted and ready to land.Mar 24 2018, 11:58 PM

Log the failing seat name.

undo my git messup

Do you have commit access?

I don't think I have commit access

libinput/connection.cpp
141

I guess I could do
qCWarning(KWIN_LIBINPUT) << "Failed to assign seat" << LogindIntegration::self()->seat();

undo another git messup

arc failed to apply this one. Could you please rebase again?

I am trying. It keeps pulling D9551 for some reason, and then making it part of the diff... I am going to turn off the dependency on it

was this rebase correct?

rkflx added a comment.Apr 18 2018, 1:06 PM

was this rebase correct?

Looks like it.

This revision was automatically updated to reflect the committed changes.