| habacker |
| KMyMoney |
add_library() may add a "lib" prefix to the plugin's filename, which causes it not to be found.
Using kde4_add_plugin() instead again fixes that.
This change to add_library() was (accidentally?) backported from the KF5 version in commit c78183f18201 .
BUG: 386547
FIXED-IN: 4.8.2
Intended for the 4.8 branch only, of course.
The plugin is again installed as konlinetasks_sepa.so here (like in 4.8.0, and also the KF5 port).
The error message that the plugin could not be found does not occur anymore, kmymoney prints
onlineTask available "org.kmymoney.creditTransfer.sepa"
to stdout now.
Haven't tested the actual functionality though.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Your change looks OK to me and I appreciate your testing. I would like to have Ralf an eye on it as he is actively working on the 4.8 branch.
I can confirm that there is a issue with this plugin in the recent public available kmymoney4 release
xxx:~ # rpm -q -l kmymoney-4.8.1.1 | grep lib64/kde4
/usr/lib64/kde4/kcm_kmm_icalendarexport.so
/usr/lib64/kde4/kcm_kmm_printcheck.so
/usr/lib64/kde4/kmm_csvexport.so
/usr/lib64/kde4/kmm_csvimport.so
/usr/lib64/kde4/kmm_icalendarexport.so
/usr/lib64/kde4/kmm_kbanking.so
/usr/lib64/kde4/kmm_ofximport.so
/usr/lib64/kde4/kmm_printcheck.so
/usr/lib64/kde4/kmm_reconciliationreport.so
/usr/lib64/kde4/kmm_weboob.so
/usr/lib64/kde4/libkonlinetasks_sepa.so
-> this is wrong
/usr/lib64/kde4/payeeidentifier_iban_bic_delegates.so
/usr/lib64/kde4/payeeidentifier_ibanbic_storageplugin.so
/usr/lib64/kde4/payeeidentifier_nationalAccount_ui.so
/usr/lib64/kde4/payeeidentifier_nationalaccount_storageplugin.so
I also found this commit https://cgit.kde.org/kmymoney.git/commit/kmymoney/plugins/onlinetasks/sepa?h=4.8&id=c78183f18201b16436008ea4306a974f180141d7, which shows that using kde_add_plugin is the correct was to solve this issue.
Erm, the commit has the wrong author:
Andreas Mayer filed the bug report, the patch is by me... ;-)
Nevermind though.
The important thing is that it's fixed.
Sorry, this issue seemed to be caused by phabricator or wrong phabricator usage. Running
arc patch --nobranch D9545
did run "git am" with the patch on the recent branch with my name as author, which was wrong. Then I searched for the original author and oversaw that. I'm going to file a sysadmin request to correct the commit.
! In D9545#183971, @habacker wrote:
I'm going to file a sysadmin request to correct the commit.
see T7657
It is a known problem that uploading a patch via the web UI of Phabricator strips authorship information. You could use arc diff for uploading the patch to avoid this.
I'm going to file a sysadmin request to correct the commit.
The task is private so I cannot see what was done there yet. However, I'm not sure whether retroactively changing the git history is good advice. You could also just add a reverting commit and push the correct patch after that. HTH ;)