Fix system tray settings if placed on desktop
ClosedPublic

Authored by davidedmundson on Dec 27 2017, 11:11 PM.

Details

Summary

The DesktopView replaces the default ConfigView for itself with a
specialised ContainmentConfigView. It's only loaded by the desktop, and
is more of a Desktop-ConfigView than generic containment.

The system tray applet doesn't show it's own config, but instead shows a
config of its internal system tray containment by overriding the
configure action.

This causes the desktop view to mistakenly shows it's specialised
desktop config view when the system tray is configured.

This patch adds an explicit check on the containment type.

Test Plan

Clicked on sys tray settings on desktop
Clicked on normal desktop settings
Clicked on sys tray settings on panel

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Plasma. · View Herald TranscriptDec 27 2017, 11:11 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Dec 27 2017, 11:11 PM
broulik accepted this revision.Jan 2 2018, 10:39 AM
This revision is now accepted and ready to land.Jan 2 2018, 10:39 AM
This revision was automatically updated to reflect the committed changes.