Pass SwitchEvent from LibInput through KWin and add to DebugConsole
ClosedPublic
Actions

Authored by graesslin on Dec 27 2017, 7:27 PM.

Details

Reviewers

Group Reviewers

KWin
Plasma

Commits

R108:d2a9232ad34f: Pass SwitchEvent from LibInput through KWin and add to DebugConsole

Summary

This change introduces a new SwitchEvent and passes it through the
InputEventSpy and InputEventFilter. The DebugConsoleFilter implements it
so that the events can be monitored in the debug console.

Test Plan

Untested as my only device with such switches has too old libinput

Diff Detail

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin created this revision.Dec 27 2017, 7:27 PM

Restricted Application added a project: KWin. · View Herald TranscriptDec 27 2017, 7:27 PM

Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript

graesslin requested review of this revision.Dec 27 2017, 7:27 PM

Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptDec 27 2017, 7:27 PM

graesslin added a dependency: D9516: [libinput] Add support for switch devices and events.Dec 27 2017, 7:28 PM

Restricted Application edited projects, added KWin; removed Plasma. · View Herald TranscriptDec 27 2017, 7:28 PM

ngraham added a subscriber: ngraham.Dec 27 2017, 9:58 PM

Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptDec 27 2017, 9:58 PM

mart accepted this revision.Jan 8 2018, 4:00 PM

This revision is now accepted and ready to land.Jan 8 2018, 4:00 PM

Restricted Application edited projects, added KWin; removed Plasma. · View Herald TranscriptJan 8 2018, 4:00 PM

mart mentioned this in D9764: A basic TabletModeManager.Jan 9 2018, 1:53 PM

Closed by commit R108:d2a9232ad34f: Pass SwitchEvent from LibInput through KWin and add to DebugConsole (authored by graesslin). · Explain WhyJan 9 2018, 6:33 PM

This revision was automatically updated to reflect the committed changes.

Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptJan 9 2018, 6:33 PM

mart mentioned this in R108:1be5256b1b43: A basic TabletModeManager.Jan 11 2018, 12:11 PM

Revision Contents
Changeset List

			Path	Packages
M			autotests/libinput/input_event_test.cpp (31 lines)
M			debug_console.h (2 lines)
M			debug_console.cpp (37 lines)
M			input.h (3 lines)
M			input.cpp (15 lines)
M			input_event.h (27 lines)
M			input_event.cpp (9 lines)
M			input_event_spy.h (3 lines)
M			input_event_spy.cpp (5 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	24404	1532c14		Dec 27 2017, 7:27 PM	★	★
Diff 2	25035	8a3128c	R108:d2a9232ad34f1c6e2fa5aa8e7fe87f41fe72f5b3	Jan 9 2018, 6:32 PM	★	★

	Status	Author	Revision
	Closed	graesslin	D9521 Pass SwitchEvent from LibInput through KWin and add to DebugConsole
	Closed	graesslin	D9516 [libinput] Add support for switch devices and events