If the window's platform surface was destroyed, there is also
no shadow to be removed.
Both X and Wayland code will try to create the platform surface
again, and it will lead to crash in other code that doesn't expect
platform surface to be created when the containment is being deleted.
This fixes crash in PanelConfigView::event when removing panels.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Maybe we could connect to the PlatformSurfaceDestroyed event? At that point it's still valid and we can call into clearShadow?
| shell/panelshadows.cpp | ||
|---|---|---|
| 630 | shouldn't it be a dynamic_cast in this case? | |
That could work too, but is it really needed to remove shadow (one property) from the window that is going to be destroyed right after?
| shell/panelshadows.cpp | ||
|---|---|---|
| 630 | QWindow derives from QSurface, so dynamic_cast would not make a difference here? | |
yes as otherwise on X11 we are leaking pixmaps and on Wayland we are leaking buffers on both client and server.