Fix build with opencv 3.4
ClosedPublic
Actions

Authored by arojas on Dec 25 2017, 12:05 AM.

Details

Reviewers

cgilles
mqualmann

Commits

R482:27e8d931765a: Fix build with openCV 3.4

Summary

There are API changes in opencv 3.4 face module: the "load" and "save" functions have been renamed to "read" and "write". Additionally, the opencv_face library is not implicitly linked anymore, it needs to be explicitely searched for.

Test Plan

Builds with opencv 3.3 and 3.4

Diff Detail

Repository

R482 digiKam

Lint

Lint Skipped

Unit

Unit Tests Skipped

arojas requested review of this revision.Dec 25 2017, 12:05 AM

arojas created this revision.

arojas edited reviewers, added: mqualmann; removed: • qmarteen.

The patch is fine for me and can be applied to git master.

Note : For future digiKam 6.0.0, it will be time to drop OpenCV 2.X support.

Gilles Caulier

This revision is now accepted and ready to land.Dec 25 2017, 7:23 AM

mqualmann accepted this revision.Dec 25 2017, 7:41 AM

Closed by commit R482:27e8d931765a: Fix build with openCV 3.4 (authored by arojas). · Explain WhyDec 25 2017, 9:35 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (2 lines)
M			libs/facesengine/opencv3-face/face.hpp (17 lines)
M			libs/facesengine/opencv3-face/facerec.cpp (16 lines)
M			libs/facesengine/recognition-opencv-lbph/facerec_borrowed.h (13 lines)