Highlighting indexer: Warn about empty attributes
ClosedPublic

Authored by dhaumann on Dec 23 2017, 9:20 PM.

Details

Summary

This patch extends the highlighting indexer to search for
attribute="". Referencing an empty attribute is most likely
an error.

In fact, this check finds one issue, and one false positive.
Still, it's better to fix it properly to ensure conformance.

Test Plan

make test

Diff Detail

Repository
R216 Syntax Highlighting
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dhaumann created this revision.Dec 23 2017, 9:20 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 23 2017, 9:20 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
dhaumann requested review of this revision.Dec 23 2017, 9:20 PM
vkrause accepted this revision.Dec 24 2017, 1:03 PM
This revision is now accepted and ready to land.Dec 24 2017, 1:03 PM
This revision was automatically updated to reflect the committed changes.