Prevent dataloss in text editor.
ClosedPublic

Authored by woltherav on Dec 23 2017, 7:51 PM.

Details

Summary

This patch does two things:

first, the converter when going from html to svg doesn't contain svg, so it comments out the converter.toSVG(svg, styles) function(which would lead to empty strings).

This should proly be replaced with the converter actually creating text-chunks or something from the svg, but eh.

The second bit is does is to prevent toHTML attempting to write style attributes in the br tag? It's a bit odd but it happens without an extra span. Might proly also benefit from reworking.

Diff Detail

Repository
R37 Krita
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
woltherav requested review of this revision.Dec 23 2017, 7:51 PM
woltherav created this revision.
rempt accepted this revision.Dec 28 2017, 12:35 PM
This revision is now accepted and ready to land.Dec 28 2017, 12:35 PM
This revision was automatically updated to reflect the committed changes.