Differential D9485

Send the correct hostname with the HELO/EHLO command
ClosedPublic
Actions

Authored by fvogt on Dec 22 2017, 10:24 PM.

Details

Reviewers
mlaurent
dvratil
Commits
R733:5199ed07428a: Send the correct hostname with the HELO/EHLO command
Summary

It sent the server's hostname previously, which some reject.

BUG: 387926

Test Plan

Ran nc as smtp server, uses the right hostname for EHLO now.

Diff Detail

Repository
R733 KSmtp
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
fvogt created this revision.Dec 22 2017, 10:24 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptDec 22 2017, 10:24 PM
Restricted Application added a subscriber: KDE PIM. · View Herald Transcript
fvogt requested review of this revision.Dec 22 2017, 10:24 PM
dvratil accepted this revision.Dec 23 2017, 11:47 AM

Looks good, thank you!

Please commit to Applications/17.12 branch.

This revision is now accepted and ready to land.Dec 23 2017, 11:47 AM
Closed by commit R733:5199ed07428a: Send the correct hostname with the HELO/EHLO command (authored by fvogt). · Explain WhyDec 23 2017, 12:09 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/session.cpp (14 lines)

Diff 24323

View Options

src/session.cpp

Loading...