| ederag |
Following D9244, update KateConsole::slotSync (the directory synchronization in terminal)
to use KTextEditor::Message as an information, when the file is not local.
Previously, a string starting with ### was output to the terminal.
This might have been annoying if the # character was not a comment
for the interpreter currently running in the terminal.
The chosen level is just "Information", because when
"Automatic synchronize" is on,
the expected behavior is just a no-op.
Open two files in different directories,
as well as a remote file.
Switching between them and
Tools>Synchronize Terminal with Current Document
or in the Terminal Settings,
check Automatically synchronize the terminal with the current document when possible)
Upon switching to the remote file, a blue message should appear at the top:
Terminal not synchronized with current document, because <document url path> is not a local file
| Lint Skipped |
| Unit Tests Skipped |
What happens, if you edit several remove documents and switch a lot.
Will this "spam" the current view with the info message again and again?
Is this also displayed, when the terminal toolview is hidden? I would hope not, since maybe the user is no interested at all in the message in this case.
Ideally, the konsole should display this kind of information, and not the view. So far, I am not sure that we really want this.
Switching back and forth,
there is only one info message, at the top,
spammed several times if switching really fast
(say, more than once per second).
About the spamming, it would be nice to
collapse identical messages in the same view into one,
just resetting the timer.
But there is something weird:
sometimes, the message is stuck there.
And other messages seem locked out
(for instance, trying run in Terminal should issue an error message,
which does not appear)
Closing the document and reopening, everything is back to normal.
KDE Frameworks 5.26.0
Qt 5.6.1 (built against 5.6.1)
Is this also displayed, when the terminal toolview is hidden?
Yes.
I would hope not, since maybe the user is no interested at all in the message in this case.
Probably not in the AutoSync case.
Ideally, the konsole should display this kind of information, and not the view.
That's a possibility.
But having the message in the document view does help spotting the origin.
So far, I am not sure that we really want this.
Maybe add an option like "Inform about non-local files" for AutoSync,
off by default ?
This makes sense, and would suppress the spamming issue.
Let me recall that the current messages are invasive, actually:
Previously, a string starting with ### was output to the terminal.
This might have been annoying if the # character was not a comment
for the interpreter currently running in the terminal.
I do not really care, just making sure that this point did not get buried behind details.