Differential D9474

[Kickoff / Kicker] Move "Add to favorites" entry to the bottom of the context menu
ClosedPublic
Actions

Authored by broulik on Dec 22 2017, 10:29 AM.

Details

Reviewers
hein
ivan
Group Reviewers
Plasma
Commits
R119:55eabda75ae6: [Kickoff / Kicker] Move "Add to favorites" entry to the bottom of the context…
Summary

Otherwise draws attention away from jump list actions and other more frequently used actions.
This got changed with the introduction of per-activity favorites.

Test Plan

"Add to favorites" and "Remove from favorites" actions are now at the bottom of the list.
"Show in favorites" menu is also at the bottom and works fine

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Dec 22 2017, 10:29 AM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 22 2017, 10:29 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Dec 22 2017, 10:29 AM
ngraham added a subscriber: ngraham.Dec 27 2017, 2:22 AM

Fine by me.

abetts added a subscriber: abetts.Dec 27 2017, 3:29 PM

Can you post an image of what this will look like?

hein added a comment.Jan 1 2018, 11:04 AM

I'll wait for the screenshot, but in general I agree with and like this.

broulik added a comment.Jan 2 2018, 12:24 PM

Before


After

Especially if you have more actions at the top like "Open new tab" and the like, the favorite entry at the top would really be out of place

hein added a comment.Jan 2 2018, 3:24 PM

Does the add fav stuff also move to the bottom?

broulik added a comment.Jan 2 2018, 3:26 PM

Yes, and so is the activity-related stuff, see "Test plan"

hein accepted this revision.Jan 2 2018, 3:38 PM
This revision is now accepted and ready to land.Jan 2 2018, 3:38 PM
Closed by commit R119:55eabda75ae6: [Kickoff / Kicker] Move "Add to favorites" entry to the bottom of the context… (authored by broulik). · Explain WhyJan 4 2018, 8:26 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 24697

View Options

applets/kicker/package/contents/code/tools.js

Loading...
View Options

applets/kickoff/package/contents/code/tools.js

Loading...