KCM: add support for non-integer output scaling
AbandonedPublic
Actions

Authored by dvratil on Dec 21 2017, 3:35 PM.

Details

Reviewers

sebas
davidedmundson

Summary

The KCM only supported integer scaling factors, but with XRandR we actually can
(and want to) support non-integer scaling factors. To accommodate for that, a
QDoubleSpinBox is used instead of a QComboBox in the KCM when the backend
reports that it supports non-integer scaling factors.

Diff Detail

Repository

R104 KScreen

Lint

Lint Skipped

Unit

Unit Tests Skipped

dvratil created this revision.Dec 21 2017, 3:35 PM

Restricted Application added a project: Plasma. · View Herald TranscriptDec 21 2017, 3:35 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

dvratil requested review of this revision.Dec 21 2017, 3:35 PM

dvratil added a dependency: D9463: XRandR: implement scaling support.

ngraham added a subscriber: ngraham.Dec 27 2017, 2:21 AM

This would leave the X KCM with two scaling settings.

The combo box
And the dialog with the button at the bottom

That's going to result in a much bigger refactoring as you have to handle the env vars used by startkde and the font DPI setting.

This revision now requires changes to proceed.Dec 27 2017, 1:52 PM

Also, any UI change needs screenshots attached how it looks with the change.

dvratil abandoned this revision.Feb 25 2020, 4:36 PM

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (2 lines)
M			console/console.cpp (2 lines)
M			kcm/src/controlpanel.cpp (2 lines)
M			kcm/src/kcm_kscreen.cpp (3 lines)
M			kcm/src/outputconfig.h (14 lines)
M			kcm/src/outputconfig.cpp (56 lines)