Since the change in libkscreen modes are now always unscaled, so there's no
need to divide them by the scale factor. Instead, we actually want them
shown scaled appropriately in the UI so that user can see how the screens will
look in the correct ratio.
Details
Details
- Reviewers
sebas davidedmundson
Diff Detail
Diff Detail
- Repository
- R104 KScreen
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
iIf we have your patch with the scaled modes, then we woudln't need to divide here, sure.
But why would we multiply it??
The size should be the size in normalised space.
Comment Actions
If mode reports resolution 1920x1080, but the screen is scaled by 2, then we want to show the output rectangle in KCM to be 3840x2160 so that it's in the correct ratio. If you put the scaled output next to a HiDPI output (3840x2160) in the KCM the rectangles should both be the same size. Hence the multiplication.
Comment Actions
If I have a 2000x2000 montior at scale 2
I want it to appear the same size as a 1000x1000 monitor at scale 1.
Or in other terms:
We want to see things at their logical size, not their device size.
Comment Actions
Indeed, I'll rework the whole scaling thing to abstract away the difference between scaling in Wayland and in X11 including the UI side (it's not related to the OSD changes, I'm just trying to work around my silly decision to get a hi-dpi monitor alongside a regular one)