Fix messed up menus after closing a detached tab
ClosedPublic

Authored by ahmadsamir on Dec 21 2017, 11:26 AM.

Details

Summary

This should fix Bug 348478 [1].

To reproduce the issue:

  • open a konsole window and open more than one tab
  • detach one of them
  • close the detached tab
  • try to use e.g. the Edit menu, it doesn't work

The issue is that _pluggedController in sessionFinished() after closing the detached tab doesn't point to the SessionController of the "session" from the sender, but actually points to the SessionController of the session of the tab that's active in the original window; so calling unplugController on it messes up the menus.

[1] https://bugs.kde.org/show_bug.cgi?id=348478

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahmadsamir created this revision.Dec 21 2017, 11:26 AM
ahmadsamir created this object with edit policy "Administrators".
Restricted Application added a project: Konsole. · View Herald TranscriptDec 21 2017, 11:26 AM
Restricted Application added a subscriber: Konsole. · View Herald Transcript
ahmadsamir requested review of this revision.Dec 21 2017, 11:26 AM
This revision was automatically updated to reflect the committed changes.