Differential D9436

Add missing types to qmldir
ClosedPublic
Actions

Authored by arojas on Dec 20 2017, 5:06 PM.

Details

Reviewers
gottfried
apol
Group Reviewers
KDE Edu
Commits
R335:4e90e87e7522: Add missing types to qmldir
R335:09f6df15b663: Mark Label and LineLabel types as internal
Summary

Otherwise ktouch will refuse to load with Qt 5.10, which seems to be more strict with respect to QML files loading.

Test Plan

ktouch runs with Qt 5.10

Diff Detail

Repository
R335 KQtQuickCharts
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
arojas created this revision.Dec 20 2017, 5:06 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptDec 20 2017, 5:06 PM
arojas requested review of this revision.Dec 20 2017, 5:06 PM
apol accepted this revision.Dec 20 2017, 5:22 PM
This revision is now accepted and ready to land.Dec 20 2017, 5:22 PM
Closed by commit R335:4e90e87e7522: Add missing types to qmldir (authored by arojas). · Explain WhyDec 20 2017, 8:10 PM
This revision was automatically updated to reflect the committed changes.
fvogt added a subscriber: fvogt.Dec 21 2017, 1:06 PM

AFAICS those are not supposed to be public, so they need to be marked as "internal". See https://phabricator.kde.org/D8077

gottfried reopened this revision.Dec 21 2017, 1:21 PM

As @fvogt has already noticed, Label and LineLabel are not part of the public API. Please add the internal qualifier to added types.

This revision is now accepted and ready to land.Dec 21 2017, 1:21 PM
gottfried requested changes to this revision.Dec 21 2017, 1:23 PM

Please add internal qualifiers.

This revision now requires changes to proceed.Dec 21 2017, 1:23 PM
arojas updated this revision to Diff 24221.Dec 21 2017, 1:30 PM

Made Label and LineLabel internal

gottfried accepted this revision.Dec 21 2017, 1:38 PM

Thanks for the patch!

This revision is now accepted and ready to land.Dec 21 2017, 1:38 PM
Closed by commit R335:09f6df15b663: Mark Label and LineLabel types as internal (authored by arojas). · Explain WhyDec 22 2017, 7:23 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/qml/qmldir (4 lines)

Diff 24272

View Options

src/qml/qmldir

Loading...