Prevent window flickering on startup
ClosedPublic

Authored by volkov on Dec 20 2017, 3:09 PM.

Details

Summary

Don't show DialogChooseBackends until it has been inserted
into the layout, otherwise it shows as a toplevel window
and then immediately hides.

Diff Detail

Repository
R345 KMix
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
volkov requested review of this revision.Dec 20 2017, 3:09 PM
volkov created this revision.
marten accepted this revision.Dec 20 2017, 3:48 PM

Well spotted, thanks.

This revision is now accepted and ready to land.Dec 20 2017, 3:48 PM
volkov closed this revision.Dec 20 2017, 3:53 PM

Shouldn't this also go into Applications/17.12?

I think it should. Is it ok to cherry-pick -x it there?

I think it should. Is it ok to cherry-pick -x it there?

Yes. I think most projects merge up from Applications/x.y to master, but it's a tiny bit late for that ;)

Hmm, why late?