Fixes for query designers and query data view(logic, memory and stability fixes)
ClosedPublic

Authored by staniek on Dec 19 2017, 12:41 PM.

Details

Summary

(Thanks to the ASAN project for helping with many of these fixes)

  1. Synchronize the "dirty" flag between Design and Text views

For now only used by Query Designer

  1. GIT_SILENT Make *ownedByWindow required (simplify code), update docs
  1. SQL designer: remove possible memory leak if the parsed query object is still present on destruction
  1. Queries: fix possible crash in data view when the query design changes in a design view

Before replacing old query schema by a new one unassign the old from the data view.

  1. Queries: after parsing the SQL only assume the query changed if the SQL differs from the previous SQL

This reduces number of refreshes in Design and Data view.

Test Plan

Please also apply D9410 to KDb and test with it.

Play with all 3 query views for trivial and non-trivial queries.
Including tables having lookup fields is recommended too.

Diff Detail

Repository
R71 Kexi
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
staniek created this revision.Dec 19 2017, 12:41 PM
Restricted Application added a project: KEXI. · View Herald TranscriptDec 19 2017, 12:41 PM
staniek requested review of this revision.Dec 19 2017, 12:41 PM
staniek retitled this revision from Fixes for query designers and query data view (logic, memory and stability fixes) to Fixes for query designers and query data view(logic, memory and stability fixes).Dec 19 2017, 12:48 PM
staniek edited the summary of this revision. (Show Details)
piggz accepted this revision.Jan 11 2018, 8:00 AM
This revision is now accepted and ready to land.Jan 11 2018, 8:00 AM
This revision was automatically updated to reflect the committed changes.