Fix TagLib detection and build on Windows
ClosedPublic

Authored by leinir on Dec 18 2017, 2:44 PM.

Details

Summary

Due to stricter setups on Windows, TagLib was detected but the includes were not found. This patch fixes this discrepancy. It further fixes some implicit conversions which were disallowed (from QByteArray to TagLib::Filename). End result: kio-extras builds on Windows again. No idea how long it's been like this, but it's a long time.

Test Plan

Without patch: cmake finishes and finds taglib, build fails because includes are not found
With patch: cmake finishes and finds taglib, build competes because includes are found, and implicit conversions are now explicit.

Diff Detail

Repository
R320 KIO Extras
Lint
Lint Skipped
Unit
Unit Tests Skipped
leinir requested review of this revision.Dec 18 2017, 2:44 PM
leinir created this revision.
leinir added a reviewer: Frameworks.
kfunk accepted this revision.Dec 18 2017, 10:29 PM
This revision is now accepted and ready to land.Dec 18 2017, 10:29 PM
This revision was automatically updated to reflect the committed changes.