Currently, loginstatusChanged() signal is emitted nowhere in rocketchataccountsettings

• New test is created to check logout().

I think After calling loadsettings() on a RocketChatAccountSetting object, serverUrl is set to (demo.rocket.chat) and before calling it has empty sting....!

tests are written in different methods.

Tests are written in different methods.

There is still the same problem.
As I want that you test is:
const QString username = QStringLiteral("foo");
sampleChat->setUserName(username);
QCOMPARE(spyname.count(), 1); => normal it emits signal

and after:
sampleChat->setUserName(username);
QCOMPARE(spyname.count(), 1); => normal it doesn't emit new signal
but we are sure that username is not empty.
At the moment you don't assign value to username => it will compare with empty string it's a special case.
I want to compare with real case

same for other method.

But it's the last changes to do :)

Why it's empty ? not finish yet ?
or you mustn't test it
if you mustn't test it better to remove it.

still not for serverurl => comment is not correct (and it will not correct as by default we will fallback to demo...)

that signal( LoginStatusChanged() ) is triggered nowhere in the rocketchataccountsettings.cpp file!!

I thought that you will do some modifications in the rocketchataccountsettings.cpp file and then we can add tests for that..

If you say there is no need to test it, I will remove it.

Comment removed!!

Here it is empty that means before we call loadSetting(), chat.serverUrl() is returning an empty string. That's why I wrote by default it should return empty.

Anyways I removed the comment, It should not create confusion in future:)

ok with empty but why you don't want to test twice same no empty username and look at that we don't emit twice the signal ?

Here one signal should be emitted, Since we are assigining a new Url("bla bla").

This emission of the signal will append one item to the list(SpyURL) => count is 1.

Here one more signal is emitted when we assign a new Url(emptyString).

This emission of the signal will append one more item to the same the list(SpyURL) =>total count is = prevCount + 1 that is 2.

Here signal is not emitted when we assign same Url as prv.(emptyString).

There no emission and item will not be appended to lis(SpyURL) => total count is = prevCount + 0 that is 2.

ok I know that you use 2 empty string
but why you don't change it as non empty serverUrl ? it's more realistic value no ?
by default we use no empty serverurl :)

same here why emptystring and not 'no empty string' ?

in some code we can evaluate empty string as special case

it's for that that I ask you to use no empty string.

> you can use same code with no empty string :)

Here in this method(shouldNotEmitSignalWhenNewServerUrlIsSamaAsOld() ),

is it checked with non-empty string!!, and that is why I didn't check is that method:)

same idea is implemented for userNameChanged also...!

ok for here as default servername is not empty by default ok.

but I don't see it in:

void RocketChatAccountSettingsTest::shouldEmitSignalWhenUserNameChanged()
{

RocketChatAccountSettings *SampleChat = new RocketChatAccountSettings;

QSignalSpy SpyName(SampleChat, &RocketChatAccountSettings::userNameChanged);
SampleChat->setUserName(QStringLiteral("Donald Knuth"));
QCOMPARE(SpyName.count(), 1);

QString emptyString;
SampleChat->setUserName(emptyString);
QCOMPARE(SpyName.count(), 2);

SampleChat->setServerUrl(emptyString);
QCOMPARE(SpyName.count(), 2);

}

where do you test "value is not empty here ?
otherwise its not in this method
but here you test:

string not empty =>emit signal

after that you use emptyString

> no empty -> empty => signal

but after that you test 'empty -> empty' ok no signal

but I ask you 'non empty -> no empty' (with same value)

it's still not the case here no ?
otherwise give me the good method perhaps I didn't see the good method.

it's serverUrl here not setUserName

I modified the code in shouldNotEmit method.

Sorry, It's my mistake !!

I corrected it :)