Differential D9338

[comic] Fix comic updater time interval
ClosedPublic
Actions

Authored by anthonyfieroni on Dec 14 2017, 6:56 PM.

Details

Reviewers
davidedmundson
broulik
mart
Group Reviewers
Plasma
Commits
R114:095196ca6438: [comic] Fix update interval
Summary

In case of invalid update interval every hour download manager stores entries of every request. It's memory expensive because every entry has a complete images.
In case of valid update interval after that again download manager stores entries regularly every hour.
This patch fixes this issues and reduce memory consumption when comic applet is used.

Test Plan

Manually tested

Diff Detail

Repository
R114 Plasma Addons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
anthonyfieroni created this revision.Dec 14 2017, 6:56 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 14 2017, 6:56 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
anthonyfieroni requested review of this revision.Dec 14 2017, 6:56 PM
anthonyfieroni added a comment.Dec 18 2017, 12:24 PM

I plan to commit it this week, please review it, does something is not correct?

davidedmundson added inline comments.Dec 22 2017, 9:35 AM
applets/comic/comicupdater.cpp
56

wouldn't you still need to call checkForUpdate() if you went into this path?

Especially as checkForUpdate is the one that sets up the timer to call itself again

86

I assume this line is the important change?

+1 to this bit.

davidedmundson added a comment.Dec 22 2017, 9:59 AM

Can you please fill in the "testing done" field on phabricator.

anthonyfieroni updated this revision to Diff 24295.Dec 22 2017, 1:28 PM
anthonyfieroni marked 2 inline comments as done.
anthonyfieroni edited the test plan for this revision. (Show Details)
anthonyfieroni added inline comments.
applets/comic/comicupdater.cpp
86

Yes.

davidedmundson accepted this revision.Dec 22 2017, 1:38 PM
This revision is now accepted and ready to land.Dec 22 2017, 1:38 PM
Closed by commit R114:095196ca6438: [comic] Fix update interval (authored by anthonyfieroni). · Explain WhyDec 22 2017, 2:55 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mapplets/comic/comicupdater.cpp (11 lines)

Diff 24303

View Options

applets/comic/comicupdater.cpp

Loading...