Change "Empty Search" to just "Search" to handle searches with no search text
ClosedPublic

Authored by ngraham on Dec 13 2017, 5:55 AM.

Details

Summary

BUG: 387854

The pre-defined searches (Documents, Videos, etc) all default to no search text. https://cgit.kde.org/dolphin.git/commit/?id=702429ac8e64a5aff4e110a56f526b96ecb795fd changed their window title from "baloosearch - /" to "Empty Search", but the search isn't really empty; it just lacks a search string. It's still looking for documents, or videos, or whatever.

Test Plan

Is it too late to get this into 5.12?

Tested in KDE Neon. Before:

After:

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham requested review of this revision.Dec 13 2017, 5:55 AM
ngraham created this revision.
ngraham edited the test plan for this revision. (Show Details)Dec 13 2017, 5:56 AM
ngraham edited the test plan for this revision. (Show Details)Dec 13 2017, 5:59 AM
broulik accepted this revision.Dec 13 2017, 9:35 AM
This revision is now accepted and ready to land.Dec 13 2017, 9:35 AM

Too late for 5.12, will land on master.

This revision was automatically updated to reflect the committed changes.

Did you mean 17.12?

Sorry, yes. I keep saying 5.12 when I mean 17.12. I merged to master since 17.12 is due to be released tomorrow and this is a string change, but we're past the string freeze date. If that was a mistake, let me know and I can cherry-pick it to the 17.12 branch as well.

@ngraham Usually you can ask for a string freeze exception by sending a mail on the kde-i18n-doc list.

Thanks, done.