disappearing scrollbars on mobile
ClosedPublic

Authored by mart on Dec 11 2017, 1:27 PM.

Details

Summary

like other platforms, on mobile devices make scrollbars visible only when
dragging/flicking, behavior on desktop unchanged
it introduces a runtime dependency on kirigami, but was already kinda there
but broken as the Settings singleton was already used.
if this can't be done, i'll add something in plasmacore which reads as well the
QT_QUICK_CONTROLS_MOBILE environment variable

Test Plan

scrollbar disappearing with the variable set, normal behavior otherwise

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart created this revision.Dec 11 2017, 1:27 PM
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptDec 11 2017, 1:27 PM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
mart requested review of this revision.Dec 11 2017, 1:27 PM

If we have a runtime dep, we need to make it explicit in CMakeLists.txt.

src/declarativeimports/plasmacomponents3/private/DefaultListItemBackground.qml
22–23

does this change kill this?

If so +1000

mart added inline comments.Dec 12 2017, 1:52 PM
src/declarativeimports/plasmacomponents3/private/DefaultListItemBackground.qml
22–23

ah, yes it does, will remove

mart updated this revision to Diff 23809.Dec 12 2017, 1:55 PM
  • fix deps
mart marked 2 inline comments as done.Dec 12 2017, 1:56 PM
davidedmundson accepted this revision.Dec 12 2017, 1:58 PM
This revision is now accepted and ready to land.Dec 12 2017, 1:58 PM
This revision was automatically updated to reflect the committed changes.