Fix indentation of icon for left aligned toolbuttons
ClosedPublic

Authored by rkflx on Dec 10 2017, 7:33 PM.

Details

Summary

Gwenview's Operations sidebar uses custom QToolButtons which are
wide and left aligned. Special support for this in Oxygen was added with
b33942690c65. However, compared to the KDE4 version there is not enough space
between the left button border and the icon (Screenshots from the
matching Diff for Breeze, see D9281):

This is fixed by adding the appropriate margin:

Note how this replicates exactly the spacing of the toolbuttons in the
regular toolbar on the top (which had its icon size set to "small" in
this screenshot).

CCBUG: 381535

Test Plan

Icons on toolbuttons in Gwenview's Operations sidebar no longer
squished all the way to the left, text spacing still looking good.

Diff Detail

Repository
R113 Oxygen Theme
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
rkflx created this revision.Dec 10 2017, 7:33 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 10 2017, 7:33 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
rkflx requested review of this revision.Dec 10 2017, 7:33 PM
rkflx edited the summary of this revision. (Show Details)Dec 10 2017, 7:53 PM
This revision was automatically updated to reflect the committed changes.