Fix indentation of icon for left aligned toolbuttons
ClosedPublic

Authored by rkflx on Dec 10 2017, 7:30 PM.

Details

Summary

Gwenview's Operations sidebar uses custom QToolButtons which are
wide and left aligned. Special support for this in Breeze was added with
2fb62271d777. However, compared to the KDE4 version there is not enough space
between the left button border and the icon:

This is fixed by adding the appropriate margin:

Note how this replicates exactly the spacing of the toolbuttons in the
regular toolbar on the top (which had its icon size set to "small" in
this screenshot).

CCBUG: 381535

Test Plan

Icons on toolbuttons in Gwenview's Operations sidebar no longer
squished all the way to the left, text spacing still looking good.

Diff Detail

Repository
R31 Breeze
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
rkflx created this revision.Dec 10 2017, 7:30 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 10 2017, 7:30 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
rkflx requested review of this revision.Dec 10 2017, 7:30 PM
rkflx added a comment.Dec 10 2017, 7:39 PM

This is currently based on the master branch, but might be material for Plasma/5.11 as well. Please tell me where this should land in the end, and how merging/cherrypicking/... works in this repo (the commit history is not entirely consistent regarding this).

hpereiradacosta accepted this revision.Dec 10 2017, 7:52 PM

Thanks for the patch !
Sounds correct. Feel free to submit and to backport to plasma/5.11
You might also want to check the close to identical code for oxygen, in case it also applies.

Hugo

This revision is now accepted and ready to land.Dec 10 2017, 7:52 PM
rkflx edited the summary of this revision. (Show Details)Dec 10 2017, 7:53 PM
rkflx added a comment.Dec 10 2017, 7:56 PM

You might also want to check the close to identical code for oxygen, in case it also applies.

Has already been done in D9282, see mentions above your comment :)

This revision was automatically updated to reflect the committed changes.