that can't be right.

1. this doesn't leak

2. what's the point of making a manager?

Remove all references to them, they are unused.

Wrong indentation.

More info?

How doesn't this leak when excluding my change?

you're deleting an object immediately after show.

That will close the dialog

and then it will crash here.

The runner manager has a parent object.

http://doc.qt.io/qt-5/objecttrees.html

Should this be dereferenced outside the loop or not at all?

Thanks

When you do this origCorr is now a dangling pointer to deleted contents.

personally I'd solve this with

view->setAttribute(Qt::WA_DeleteOnClose)

and then this method can just create objects and not worry about destroying them itself.

We've just passed this to
m_editor->addCollection(m_actionCollection,
in the line above...I expect we still need our actionCollection.

Please make sure you test your changes before posting them.

You should set attribute delete on close as well.

unrelated