MessageInterface: Add CenterInView as additional position
AbandonedPublic
Actions

Authored by dhaumann on Dec 8 2017, 3:29 PM.

Details

Reviewers

cullmann
neundorf

Summary

This patch extends the message interface to support CenterInView.
This should be binary compatible, since an enum is only added at
the end.

The search messages "Search wrapped at bottom/top" now use
CenterInView to be more visible (see recent discussion on
kwrite-devel). In order to support his, a custom layout called
KateMessageLayout was added that only supports the positions
allowed by KTextEditor::Messate::MessagePosition.

Test Plan

make test, manual testing

Diff Detail

Repository

R39 KTextEditor

Branch

MessageInterface (branched from master)

Lint

No Linters Available

Unit

No Unit Test Coverage

dhaumann created this revision.Dec 8 2017, 3:29 PM

Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptDec 8 2017, 3:29 PM

Restricted Application added a subscriber: Frameworks. · View Herald Transcript

dhaumann requested review of this revision.Dec 8 2017, 3:29 PM

For the "KateMessageWidget *m_topMessageWidget" and Co. members: Would it make sense to have just an array of pointers with index == the matching MessagePosition enum value?

Simplify MessageWidget member variable handling

Remove unneeded include

Honor spacing for message widgets

ping?

I like the code better with the array ;=)
I would use the enum values instead of 5 or 2, otherwise this is fine for me.

For the actual functionality I guess Alex should say yes/no.

Abandoned in favor of followup request: https://phabricator.kde.org/D9393

Revision Contents
Changeset List

			Path	Packages
M			src/include/ktexteditor/message.h (3 lines)
M			src/search/katesearchbar.h (3 lines)
M			src/search/katesearchbar.cpp (27 lines)
M			src/view/kateview.h (20 lines)
M			src/view/kateview.cpp (65 lines)
M			src/view/kateviewhelpers.h (39 lines)
M			src/view/kateviewhelpers.cpp (82 lines)
M			src/view/kateviewinternal.cpp (12 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	23655	eb0bdd4		Dec 8 2017, 3:29 PM	★	★
Diff 2	23780	eb0bdd4	- Simplify MessageWidget member variable handling	Dec 11 2017, 10:16 PM	★	★
Diff 3	23781	eb0bdd4	- Remove unneeded include	Dec 11 2017, 10:18 PM	★	★
Diff 4	23782	eb0bdd4	- Honor spacing for message widgets	Dec 11 2017, 10:23 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
f3845cb7954d	3d2a6945680d	eb695ab11fb1	Dominik Haumann	Honor spacing for message widgets	Dec 11 2017, 10:23 PM
eb695ab11fb1	b2b5ec50d0a5	28e993b967ff	Dominik Haumann	Remove unneeded include	Dec 11 2017, 10:17 PM
28e993b967ff	b7e1cd679642	c8257dbb2dc0	Dominik Haumann	Simplify MessageWidget member variable handling	Dec 11 2017, 10:16 PM
c8257dbb2dc0	075eb1daa2d2	eb0bdd49417c	Dominik Haumann	MessageInterface: Add CenterInView as additional position (Show More…)	Dec 8 2017, 3:28 PM