do not cancel send job after 10s timeout
ClosedPublic

Authored by mkoller on Dec 8 2017, 3:20 PM.

Details

Summary

When sending a larger mail, which takes more than 10 seconds to upload to the SMTP server, the KSmtp session class always run in the onSocketTimeout() and closed the connection.
I think this is wrong since sending can take an unknown amount of time depending on the available bandwidth.

This patch avoids using a timeout for SendJobs

This patch solves my problem https://bugs.kde.org/show_bug.cgi?id=387613

Test Plan

sending large mail (> 2 MB) now works

Diff Detail

Repository
R733 KSmtp
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mkoller requested review of this revision.Dec 8 2017, 3:20 PM
mkoller created this revision.
dvratil requested changes to this revision.Dec 9 2017, 11:12 AM

Sounds sensible as a workaround until we figure out something better.

Please fix the coding style, otherwise it's good to go.

src/session.cpp
387

No spaces inside parentheses, use { } even for one-line statements

400

No spaces inside parentheses

This revision now requires changes to proceed.Dec 9 2017, 11:12 AM
This revision was automatically updated to reflect the committed changes.