Also fixed to handle the case of surfaces not having the lifespan of the
window, which the old code didn't handle.
I don't think it's worth trying to handle the case of different versions
of kwin and plasma-integration.
Details
Details
- Reviewers
graesslin - Group Reviewers
Plasma - Commits
- R135:0f3fd179c9e8: Port plasma-integration to explicit wayland AppMenu protocol
Made relevant kwin change and it gets communicated fine
Diff Detail
Diff Detail
- Repository
- R135 Integration for Qt applications in Plasma
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Martin F: One idea suggested was to use the same interface for all generic window -> kwin specific things and move the server side palette into the same interface.
It'd mean a few renames, but be a lot less work overall, particularly when we want to add new things.
Do you have an opinion on that?
Comment Actions
I'm not really used to being addressed as Martin F. yet - I just realized.
I see pro and cons for both. Personally I think it is better to have destinct interfaces for different functionality. It's easier for the case that someone else wants to reuse this. And that has already happened. Given that I would say the overhead of dedicated protocols is worth the effort.