Differential D9246

[Parley] Fix false error message when entering dashboard
ClosedPublic
Actions

Authored by hriesenbeck on Dec 7 2017, 8:40 PM.

Details

Reviewers
apol
Group Reviewers
KDE Edu
Commits
R340:c931d9200493: [Parley] Fix false error message when entering dashboard
Summary

When entering dashboard with conjugations as current practice mode, an
error message box is shown when no entries are due for practice. It
says: "The vocabulary document contains no entries that can be used for
the chosen type of practice."
For determining the word count of the collection widgets, the
EntryFilter class is used. A missing test for the showDialg flag was
added in the conjugation entries evaluation.

BUG: 387656

Diff Detail

Repository
R340 Parley
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
hriesenbeck created this revision.Dec 7 2017, 8:40 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptDec 7 2017, 8:40 PM
hriesenbeck requested review of this revision.Dec 7 2017, 8:40 PM
apol accepted this revision.Dec 10 2017, 11:56 PM
apol added a subscriber: apol.

Thanks!
Can you submit the fix or should we do it for you?

This revision is now accepted and ready to land.Dec 10 2017, 11:56 PM
Closed by commit R340:c931d9200493: [Parley] Fix false error message when entering dashboard (authored by hriesenbeck). · Explain WhyDec 11 2017, 8:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/collection/entryfilter.cpp (2 lines)

Diff 23771

View Options

src/collection/entryfilter.cpp

Loading...