Cleanup color scheme manager part of KCM Deco code
ClosedPublic

Authored by davidedmundson on Dec 7 2017, 10:28 AM.

Details

Summary

PreviewCient is internal to the KCM, it's not used by actual decorations
where we need API compatibility.
This property is not used by the KCM.

The current code parses every color scheme config file for every
decoration. This is one of the big contributing factors to this KCM
being a bit sluggish.

It was effectively deprecated in 2015 when a decoration palette was
introduced. If we wanted to add colorscheme functionality in the KCM,
we'd use that instead at a previewclient level.

Test Plan

Found this was a problem with hotspot
Grepped code for usage
Ran KCM

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Dec 7 2017, 10:28 AM
Restricted Application added a project: KWin. · View Herald TranscriptDec 7 2017, 10:28 AM
Restricted Application added subscribers: KWin, kwin, plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Dec 7 2017, 10:28 AM
graesslin accepted this revision.Dec 7 2017, 5:07 PM
This revision is now accepted and ready to land.Dec 7 2017, 5:07 PM
Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptDec 7 2017, 5:07 PM
This revision was automatically updated to reflect the committed changes.
Restricted Application edited projects, added KWin; removed Plasma. · View Herald TranscriptDec 9 2017, 12:17 AM