port wallpaper config fialog to Package::fileUrl
ClosedPublic

Authored by mart on Dec 7 2017, 9:07 AM.

Details

Summary

in the wallpaper config dialog
there was custom code duplicating listing of kpackage, just wrong
(if the same wallpaper was installed in more than one place, the
config file qml was taken from the one with least priority)

Test Plan

wallpaper dialog works again with qresource based packages
also they load the proper config ui qml file when more than one
instance of plasmashell is installed

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart created this revision.Dec 7 2017, 9:07 AM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 7 2017, 9:07 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart requested review of this revision.Dec 7 2017, 9:07 AM
broulik added a subscriber: broulik.Dec 7 2017, 9:32 AM
broulik added inline comments.
shell/containmentconfigview.cpp
132

Does that still work given you changed filePath to fileUrl.toString()?

mart added inline comments.Dec 8 2017, 11:19 AM
shell/containmentconfigview.cpp
132

yes, seems to work fine

davidedmundson accepted this revision.Dec 11 2017, 11:19 AM
davidedmundson added a subscriber: davidedmundson.

Works with my awesome firework wallpaper from 2 years ago.

shell/containmentconfigview.cpp
131

the old code has an if !package.valid {continue}

do we need that?

This revision is now accepted and ready to land.Dec 11 2017, 11:19 AM
This revision was automatically updated to reflect the committed changes.