Differential D9226

[Folder View] Don't let rubber band get null size
ClosedPublic
Actions

Authored by broulik on Dec 6 2017, 2:09 PM.

Details

Reviewers
hein
Group Reviewers
Plasma
Commits
R119:254d82a2bffe: [Folder View] Don't let rubber band get null size
Summary

This would cause the rubberband to become invisible and not match any items.

Test Plan

This is what Dolphin does. I can no longer end up with an invisible rubberband that doesnt select any files. Also keeps items from flickering when I switch between negative and positive direction as they briefly become deselected.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Dec 6 2017, 2:09 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 6 2017, 2:09 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Dec 6 2017, 2:09 PM
hein accepted this revision.Dec 9 2017, 8:35 PM
This revision is now accepted and ready to land.Dec 9 2017, 8:35 PM
hein added a comment.Dec 9 2017, 8:35 PM

Adding a comment would be nice, otherwise +1.

Closed by commit R119:254d82a2bffe: [Folder View] Don't let rubber band get null size (authored by broulik). · Explain WhyDec 13 2017, 9:44 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 23849

View Options

containments/desktop/package/contents/ui/FolderView.qml

Loading...