drop the global settings and export the service wich will activate
the appmenu kded
Details
- Reviewers
davidedmundson - Group Reviewers
KWin Plasma - Commits
- R108:6b6875166f2f: export org.kde.appmenuview
adding the menu button makes new apps export it,
removing it makes new apps using the interlal one again
Diff Detail
- Repository
- R108 KWin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Not sure. Imho the button should be there by default and shown if global menu is enabled in settings. I wouldn't want people manually having to fiddle that title bar menu button in there in order for global menu to work let alone suddenly having it use it once the button is there (update case)
Imho the button should be there by default and shown if global menu is enabled in settings
With that approach:
- users have an icon in the previews they can't see on their titlebar, which is weird.
- users of the applet still have to do two steps
- we still have that complex 4 possible options of having a button and the setting being enabled.
From a technical POV, I much prefer this. Especially on the Applet version of this patch.
From a UI POV, there's nothing to stop the old KCM setting remaining and instead manipulating the kwin buttons / running a plasma script.
IMHO it's not worth it, it's a far less intuitive place to look, but it's not something I'd object to either.
As for this patch, code here is fine, but there's stuff that could then be removed.
I'm not saying the current way it's to be configured is good, it's not, it's terrible. I really like the applet approach indeed. Mostly I'm concerned about what'll happen to existing setups when this lands, I certainly don't want appmenu to suddenly be enabled just because the appmenu button is present on the title bar (I made it the default).
(I made it the default).
You half made it the default
It's the default in kwin, it's not in the KCM default.
Which means unless a user edited this, it's not in their config unless they explicitly added it.
Which means unless a user edited this, it's not in their config unless they explicitly added it.
If that is so, then I'm all for it \o/
decorations/settings.cpp | ||
---|---|---|
158–159 | to make it not default anymore you mean? |
decorations/settings.cpp | ||
---|---|---|
158–159 | Yes please. |
appmenu.cpp | ||
---|---|---|
71 | value depends from appmenu service existing now, config values dropped |