Don't set a window icon for plasmashell
ClosedPublic

Authored by hein on Dec 5 2017, 11:42 AM.

Details

Summary

Setting a window icon is surprisingly costly and a decent chunk of
startup time. The shell doesn't need one. The only place I could
find where this icon is visible is in the KSysguard process list :).

Some people may be reminded of this rejected request:

https://git.reviewboard.kde.org/r/128484/

But that's Plasma::Dialog in plasma-framework, which (currently)
still sets an icon. This is about the shell.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
hein created this revision.Dec 5 2017, 11:42 AM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 5 2017, 11:42 AM
hein requested review of this revision.Dec 5 2017, 11:42 AM
davidedmundson accepted this revision.Dec 5 2017, 12:35 PM
This revision is now accepted and ready to land.Dec 5 2017, 12:35 PM
This revision was automatically updated to reflect the committed changes.