This fixes a regression by the removal of the busy loop call from bcdbe62660a9ca91b0d15f3a9a06a758ec8fdcda
BUG: 386246
Details
Details
New test passes with the new code, didn't pass before
Sending very small files with kde connect works again
Diff Detail
Diff Detail
- Repository
- R241 KIO
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| src/core/transferjob.cpp | ||
|---|---|---|
| 316–329 | It looks very weird to me even with single invocation call. Does it better to connect outgoing source early, when we know that job is async? | |
Comment Actions
I'm sorry, but this does not resolve https://bugs.kde.org/show_bug.cgi?id=386246 for me. KDE Connect's FileTransferJob does not even use KIO's TransferJob. It just extends KJob, so it could be a (similar) bug there.
Comment Actions
Yes it does. You don't know it but
m_reply = Daemon::instance()->networkAccessManager()->put(req, m_origin.data());
in filetransferjob.cpp is using kio.
Are you sure you know how to run kdeconnect with the patched kio to say this doesn't fix the problem for you?
Comment Actions
Yes it does. You don't know it but
m_reply = Daemon::instance()->networkAccessManager()->put(req, m_origin.data());
in filetransferjob.cpp is using kio.
I really didn't know that
Are you sure you know how to run kdeconnect with the patched kio to say this doesn't fix the problem for you?
I included a qCDebug(KIO_CORE) << "FooBar"; after the patched section and when I start the KDE Connect daemon from the Konsole I can see it in the output.
Comment Actions
Sorry guys i unsubscribed you by mistake when updating the summary.
Nicolas can you check if this fixes it for you? It does for me.