Differential D9180

port to Package::fileUrl
ClosedPublic
Actions

Authored by mart on Dec 4 2017, 5:03 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R133:b84e7fd794cb: Bump KF5 required version to 5.42
R133:fe54adf50ae2: port to Package::fileUrl
Summary

makes things work when packages are in resources

Test Plan

kscreenlocker works again

Diff Detail

Repository
R133 KScreenLocker
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart created this revision.Dec 4 2017, 5:03 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 4 2017, 5:03 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart requested review of this revision.Dec 4 2017, 5:03 PM
davidedmundson accepted this revision.Dec 4 2017, 5:04 PM
This revision is now accepted and ready to land.Dec 4 2017, 5:04 PM
Closed by commit R133:fe54adf50ae2: port to Package::fileUrl (authored by mart). · Explain WhyDec 4 2017, 5:54 PM
This revision was automatically updated to reflect the committed changes.
stikonas reopened this revision.Dec 26 2017, 3:35 PM
stikonas added a subscriber: stikonas.

You need to bump KF5 version requirement if you use this!

This revision is now accepted and ready to land.Dec 26 2017, 3:35 PM
Closed by commit R133:b84e7fd794cb: Bump KF5 required version to 5.42 (authored by stikonas). · Explain WhyDec 26 2017, 3:40 PM
This revision was automatically updated to reflect the committed changes.
stikonas added a comment.Dec 26 2017, 4:30 PM

Ok, so apparently we can't do this because 5.42 will be released after Plasma 5.12 beta. So should we revert both commits?

davidedmundson added a comment.Dec 26 2017, 4:39 PM

Ok, so apparently we can't do this because 5.42 will be released after Plasma 5.12 beta. So should we revert both commits?

Urgh. We have this same issue every single release.

I'll post a thread on the ML.

stikonas added a comment.Dec 26 2017, 4:42 PM
In D9180#183083, @davidedmundson wrote:

Ok, so apparently we can't do this because 5.42 will be released after Plasma 5.12 beta. So should we revert both commits?

Urgh. We have this same issue every single release.

I'll post a thread on the ML.

Also https://phabricator.kde.org/D9195.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (2 lines)

Diff 24378

View Options

CMakeLists.txt

Loading...